Simplify abi3 usage in pep425tags #7367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
changed the title
abi3 refers to the CPython stable ABI, so we should only ensure it applies in that particular case. This simplifies the logic in get_platforms() and makes us more compatible with the behavior of packaging.tags, which only includes abi3 for cpython_tags() and only the literal "abi3".
chrahunt
force-pushed
the
refactor/simplify-abi3
branch
from
9b14d4d
to
64ae9fd
Compare
xavfernandez
approved these changes
Nov 18, 2019
|
Thanks for reviewing. :) |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The justification for this change is similar to #7355 - our documentation states that we try our best given the user inputs for applicable wheel tag calculation. Over-complicating (and potentially over-generalizing) the inclusion criteria for abi3 in
pep425tags.get_platformsmakes it harder to integrate withpackaging.tags, which itself should represent the best-ordered and most full set of tags.Closes #7327 and progresses #6908.